Skip to content

Commit

Permalink
Code style and documentation fixes as per yoh review
Browse files Browse the repository at this point in the history
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
  • Loading branch information
TheChymera and yarikoptic committed Feb 25, 2023
1 parent 3ebf99f commit 5eae970
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions dandi/files/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ def find_dandi_files(
raise ValueError(
"Path {str(p)!r} is not inside Dandiset path {str(dandiset_path)!r}"
)
bidsdd = None
path_queue.append((Path(p), bidsdd))
path_queue.append((Path(p), None))
bids_roots = []
while path_queue:
p, bidsdd = path_queue.popleft()
Expand Down
6 changes: 3 additions & 3 deletions dandi/tests/test_validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ def test_validate_bids(bids_examples, tmp_path, dataset):

def test_validate_bids_onefile(bids_error_examples, tmp_path):
"""
Dedicated test using to single-file validation.
Dedicated test using single-file validation.
Notes
-----
* Due to the dataset-wide scope of BIDS, issues have arisen and can potentially arise again
with single-file handling. Best to keep this in to always make sure.
* Due to the dataset-wide scope of BIDS, issues with single-file handling have arisen and can
potentially arise again. Best to keep this in to always make sure.
* This can be further automated thanks to the upstream `.ERRORS.json` convention to be
performed on all error datasets, but that might be overkill since we test the datasets as
a whole anyway.
Expand Down

0 comments on commit 5eae970

Please sign in to comment.