Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dandischema to 0.6.0 #991

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Bump dandischema to 0.6.0 #991

merged 4 commits into from
Apr 6, 2022

Conversation

dchiquito
Copy link
Contributor

@dchiquito dchiquito commented Mar 30, 2022 •
edited
Loading

dandi/dandi-schema#120 made some changes to the zarr API:

  • Add size of files/directories to the serialization
  • Only record the name of the file/directory in the .checksum file instead of the entire path relative to the zarr root.
  • Add suffix -{file_count}--{file_size} to directory digests
  • ZarrChecksum.md5 -> ZarrChecksum.digest, since directories are no longer technically just an MD5
  • ZarrChecksum.path -> ZarrChecksum.name, since only the name is stored rather than the whole path.

A depressingly large number of changes are required to enact this change.

Fixes #925

@dchiquito dchiquito requested a review from jjnesbitt March 30, 2022 19:16
jjnesbitt
jjnesbitt approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, albeit a lot to take it. Just one suggestion really

dandiapi/api/zarr_checksums.py Show resolved Hide resolved
@dchiquito dchiquito added release Create a release when this pr is merged patch Increment the patch version when merged labels Apr 4, 2022
@dchiquito dchiquito merged commit a8d755c into master Apr 6, 2022
@dchiquito dchiquito deleted the dandischema-0.6.0 branch April 6, 2022 16:39
@dandibot
Copy link
Member

dandibot commented Apr 6, 2022

🚀 PR was released in v0.2.3 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 6, 2022
@jwodder jwodder mentioned this pull request Apr 6, 2022
Open
djarecka pushed a commit to djarecka/dandi-archive that referenced this pull request May 3, 2022
@mvandenburgh
Merge pull request dandi#991 from dandi/ci-set-env-vars
162e3b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh left review comments

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zarr_content_read: include sizes for the "files" (and possibly "directories")
4 participants
@dchiquito @dandibot @jjnesbitt @mvandenburgh