-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new user registration questions #2054
Conversation
@kabilar, @mvandenburgh: I moved the parenthesis from the question itself down into a bolded, italicized div right above the submit button. Take a look and lmk what you think. Particularly:
Note also that the dandi-cli integratin test is failing due to the fork not having access to the repo secrets. In this case I don't think it matters because this is purely a cosmetic change in the user signup flow (which doesn't affect the CLI). But in the future, there are apparently ways to share the appropriate secrets with forks and we can look into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (pending @kabilar and @mvandenburgh verbally approving my change).
This helps avoid the "crowding" of text that occurs in the form field itself.
Hi @mvandenburgh, this looks like the current form. |
I think the repetition is probably warranted here. I'm going to go ahead and merge, and if we want to de-duplicate the warnings, we can always do so later. |
🚀 PR was released in |
Supersedes #2038