Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange file structure #1255

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Rearrange file structure #1255

merged 2 commits into from
Aug 29, 2022

Conversation

mvandenburgh
Copy link
Member

Celery beat tasks and the dashboard view are not in the tasks/ and views/ directories, which makes them difficult to find, IMO

@mvandenburgh mvandenburgh requested a review from jjnesbitt August 26, 2022 20:39
@mvandenburgh
Copy link
Member Author

We also might want to consider moving all of the DRF ViewSets into a rest/ directory, and leave the views/ directory only for actual Django Views.

@mvandenburgh mvandenburgh removed the request for review from jjnesbitt August 26, 2022 20:46
@mvandenburgh mvandenburgh marked this pull request as draft August 26, 2022 20:46
@mvandenburgh mvandenburgh marked this pull request as ready for review August 29, 2022 14:10
@mvandenburgh mvandenburgh requested a review from jjnesbitt August 29, 2022 14:10
jjnesbitt
jjnesbitt approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree somewhat with the point of separating DRF viewsets and regular django views, although I don't think it's too critical.

@mvandenburgh mvandenburgh merged commit ebb6967 into master Aug 29, 2022
@mvandenburgh mvandenburgh deleted the rearrange-files branch August 29, 2022 14:47
@dandibot
Copy link
Member

🚀 PR was released in v0.2.44 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvandenburgh @dandibot @jjnesbitt