Use if/then/else for not masking away fail to docker login

dandi · Dec 19, 2024 · fff4f12 · fff4f12
1 parent dbfd189
commit fff4f12
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/.github/workflows/cli-integration.yml b/.github/workflows/cli-integration.yml
@@ -19,9 +19,11 @@ jobs:
 
       - name: Build Docker image
         run: |
-          [ -n "$DOCKER_LOGIN$DOCKER_TOKEN" ] \
-          && docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN" \
-          || echo "Not login-in to docker since no credentials were provided, might hit limits below"
+          if [ -n "$DOCKER_LOGIN$DOCKER_TOKEN" ]; then
+              docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN"
+          else
+              echo "Not login-in to docker since no credentials were provided, might hit limits below"
+          fi
           docker build \
             -t dandiarchive/dandiarchive-api \
             -f dev/django-public.Dockerfile \