Move authentication check into star service functions

dandi · Jan 3, 2025 · fa9eb7f · fa9eb7f
1 parent 380a7eb
commit fa9eb7f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/dandiapi/api/services/dandiset/__init__.py b/dandiapi/api/services/dandiset/__init__.py
@@ -8,7 +8,11 @@
 from dandiapi.api.services import audit
 from dandiapi.api.services.dandiset.exceptions import DandisetAlreadyExistsError
 from dandiapi.api.services.embargo.exceptions import DandisetUnembargoInProgressError
-from dandiapi.api.services.exceptions import AdminOnlyOperationError, NotAllowedError
+from dandiapi.api.services.exceptions import (
+    AdminOnlyOperationError,
+    NotAllowedError,
+    NotAuthenticatedError,
+)
 from dandiapi.api.services.version.metadata import _normalize_version_metadata
 
 
@@ -88,7 +92,7 @@ def star_dandiset(*, user, dandiset: Dandiset) -> int:
         The new star count for the Dandiset.
     """
     if not user.is_authenticated:
-        return dandiset.star_count
+        raise NotAuthenticatedError
 
     with transaction.atomic():
         DandisetStar.objects.get_or_create(user=user, dandiset=dandiset)
@@ -110,7 +114,7 @@ def unstar_dandiset(*, user, dandiset: Dandiset) -> int:
         The new star count for the Dandiset.
     """
     if not user.is_authenticated:
-        return dandiset.star_count
+        raise NotAuthenticatedError
 
     with transaction.atomic():
         DandisetStar.objects.filter(user=user, dandiset=dandiset).delete()

diff --git a/dandiapi/api/views/dandiset.py b/dandiapi/api/views/dandiset.py
@@ -582,8 +582,6 @@ def clear_uploads(self, request, dandiset__pk):
     )
     @action(methods=['POST'], detail=True)
     def star(self, request, dandiset__pk) -> Response:
-        if not request.user.is_authenticated:
-            raise NotAuthenticated
         dandiset = self.get_object()
         star_count = star_dandiset(user=request.user, dandiset=dandiset)
         return Response({'count': star_count}, status=status.HTTP_200_OK)
@@ -601,8 +599,6 @@ def star(self, request, dandiset__pk) -> Response:
     )
     @action(methods=['POST'], detail=True)
     def unstar(self, request, dandiset__pk) -> Response:
-        if not request.user.is_authenticated:
-            raise NotAuthenticated
         dandiset = self.get_object()
         star_count = unstar_dandiset(user=request.user, dandiset=dandiset)
         return Response({'count': star_count}, status=status.HTTP_200_OK)