Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to build with rust 1.80 #1779

Closed
wants to merge 2 commits into from
Closed

chore: update to build with rust 1.80 #1779

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Contributor

seeing some time related failure

error[E0282]: type annotations needed for `Box<_>`
  --> /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

has been addressed with 0.3.36, time-rs/time#693

also fixed the path borrow check issue

error[E0596]: cannot borrow `inner_relativize` as mutable, as it is not declared as mutable
  --> src/utils/path.rs:46:17
   |
41 |             *path = relative_path.to_string_lossy().into_owned();
   |             ----- calling `inner_relativize` requires mutable binding due to mutable borrow of `path`
...
46 |         let _ = inner_relativize();
  1 pick 644ca1f fix borrow check error for `path`¬
  7 # This is a combination of 2 commits.¬
   |                 ^^^^^^^^^^^^^^^^ cannot borrow as mutable

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@dandavison
Copy link
Owner

Thanks a lot @chenrui333! Both you and @th1000s fixed this, and f441d4d is already in main. But thanks a lot for the fix.

@dandavison dandavison closed this Aug 2, 2024
@chenrui333 chenrui333 deleted the rust-1.80 branch August 2, 2024 15:16
@chenrui333
Copy link
Contributor Author

Nice, good to know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants