Skip to content
This repository was archived by the owner on Feb 15, 2025. It is now read-only.

Opinionated support for ?thing params #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomsowerby
Copy link
Contributor

Current behaviour encourages

/**
 * @param string $thing
 */
function doStuff(?string $thing) { ... }

I think that it should be:

/**
 * @param string|null $thing
 */
function doStuff(?string $thing) { ... }

When the ? is present, the type is nested, with the parent type being NullableType. We deal with this already on line 156 and extract the name of the child, so we can hook into this further to add the '|null' if we have this parent/child combination.

This one might be a bit opinionated, so happy to discuss more...

Current behaviour encourages

    /**
     * @param string $thing
     */
    function doStuff(?string $thing) { ... }

I think that it should be:

    /**
     * @param string|null $thing
     */
    function doStuff(?string $thing) { ... }

When the ? is present, the type is nested, with the parent type being NullableType. We deal with this already on line 156 and extract the name of the child, so we can hook into this further to add the '|null' if we have this parent/child combination.

This one might be a bit opinionated, so happy to discuss more...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant