Apply suggestions from code review

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
danayel · Nov 25, 2020 · 15dbbee · 15dbbee
1 parent dd7f1df
commit 15dbbee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/script/graphql/build-changelog.js b/script/graphql/build-changelog.js
@@ -12,10 +12,7 @@ const fs = require('fs')
 function prependDatedEntry (changelogEntry, targetPath) {
   // Build a `yyyy-mm-dd`-formatted date string
   // and tag the changelog entry with it
-  const today = new Date()
-  const todayString = String(today.getFullYear()) + '-' +
-    String(today.getMonth() + 1).padStart(2, '0') + '-' +
-    String(today.getDate()).padStart(2, '0')
+  const today = new Date().toISOString().slice(0, 10)
   changelogEntry.date = todayString
 
   const previousChangelogString = fs.readFileSync(targetPath)

diff --git a/script/graphql/update-files.js b/script/graphql/update-files.js
@@ -58,21 +58,15 @@ async function main () {
 
     // 2. UPDATE UPCOMING CHANGES
     const upcomingChangesPath = getDataFilepath('upcomingChanges', graphqlVersion)
-    let previousUpcomingChanges = null
-    if (fs.existsSync(upcomingChangesPath)) {
-      previousUpcomingChanges = yaml.safeLoad(fs.readFileSync(upcomingChangesPath, 'utf8'))
-    }
+    const previousUpcomingChanges = yaml.safeLoad(fs.readFileSync(upcomingChangesPath, 'utf8'))
     const safeForPublicChanges = await getRemoteRawContent(upcomingChangesPath, graphqlVersion)
     updateFile(upcomingChangesPath, safeForPublicChanges)
     upcomingChangesJson[graphqlVersion] = await processUpcomingChanges(safeForPublicChanges)
 
     // 3. UPDATE SCHEMAS
     // note: schemas live in separate files per version
     const schemaPath = getDataFilepath('schemas', graphqlVersion)
-    let previousSchemaString = null
-    if (fs.existsSync(upcomingChangesPath)) {
-      previousSchemaString = fs.readFileSync(schemaPath, 'utf8')
-    }
+    const previousSchemaString = fs.readFileSync(schemaPath, 'utf8')
     const latestSchema = await getRemoteRawContent(schemaPath, graphqlVersion)
     const safeForPublicSchema = removeHiddenMembers(schemaPath, latestSchema)
     updateFile(schemaPath, safeForPublicSchema)
@@ -83,9 +77,10 @@ async function main () {
     // because the objects page is too big to render on page load
     prerenderedObjects[graphqlVersion] = await prerenderObjects(schemaJsonPerVersion)
 
+    // 5. UPDATE CHANGELOG
     if (allVersions[version].nonEnterpriseDefault) {
       // The Changelog is only build for free-pro-team@latest
-      const changelogEntry = createChangelogEntry(
+      const changelogEntry = await createChangelogEntry(
         previousSchemaString,
         safeForPublicSchema,
         safeForPublicPreviews,