You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really a bug or a feature, more just code clean up.
Loving the use of JavaScript via osascript to handle reading JSON content, however I noticed something that I assume is to be cleaned up at some point. I assume this is a hangover from a DEPNotify based script, but I am struggling to see a reason why policy_array is still a shell array when it only contains one long JSON formatted string.
Figured I'd log it here as a helpful reminder to clean up policy_array, as I haven't gone through enough of the script yet to consider creating a pull request that cleans this up.
The text was updated successfully, but these errors were encountered:
wakco
changed the title
Code Clean up - does policy_array still need to be a shell array?
Code clean up - does policy_array still need to be a shell array?
Feb 23, 2023
wakco
changed the title
Code clean up - does policy_array still need to be a shell array?
Code clean up - does policy_array in Setup Your Mac, still need to be a shell array?
Feb 23, 2023
wakco
changed the title
Code clean up - does policy_array in Setup Your Mac, still need to be a shell array?
Code clean up - does policy_array in Setup-Your-Mac-via-Dialog.bash, still need to be a shell array?
Feb 23, 2023
Cleaned up the policy_array variable, as it was being set as an array from the days of DEPNotify and no longer needed to be, and since it is a JSON, renamed it to policyJSON, matching welcomeJSON. Ref: dan-snelson#39
Also added comments above the initial setting of policyJSON for how to reconfigure the script for sourcing the policy list from an external source. Ref: dan-snelson#43
Not really a bug or a feature, more just code clean up.
Loving the use of JavaScript via osascript to handle reading JSON content, however I noticed something that I assume is to be cleaned up at some point. I assume this is a hangover from a DEPNotify based script, but I am struggling to see a reason why policy_array is still a shell array when it only contains one long JSON formatted string.
Figured I'd log it here as a helpful reminder to clean up policy_array, as I haven't gone through enough of the script yet to consider creating a pull request that cleans this up.
The text was updated successfully, but these errors were encountered: