forked from prometheus/node_exporter
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add stripped-mount-point-paths argument
* accepts a regex pattern to be removed from the mountpoints exported by the filesystem collector. * addresses issue prometheus#66
- Loading branch information
1 parent
bce2e0c
commit e707514
Showing
3 changed files
with
42 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e707514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-cleinmark Howdy!
Would you like to do a PR to the upstream node-exporter ?
e707514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zerthimon - we actually abandoned this because of confusion between the host and container when running the node_exporter as a container. Feel free to use it, but we ended up keeping the monitoring agent on the host.
e707514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-cleinmark thanks a lot for the info and the code!
Could you please elaborate on what problems have you faced when running patched node-exporter in a container (having '/rootfs' stripped from mounts). What exactly made you switch to a host-based monitoring agent ?
I'm currently in the process of decision which path to take, so your experience would be most valuable!
Thanks!