Merged
Conversation
damontecres
added
enhancement
damontecres
added a commit
that referenced
this pull request
Jan 5, 2024
Follow up to #22 Adds some basic unit tests for parsing saved filters for scenes & performers by adding a filter for every available attribute. These tests uncovered some bugs in the parsing code which are now fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
This PR does two major things:
This significantly aligns the app's UI with the web UI.
A significant amount of manual parsing is done for object filters since they do not have a graphql schema. I have not tested every single possible filter, but I suspect most (or all) will work just fine.