Skip to content

Commit

Permalink
Minor changes to studio on scene details page (#442)
Browse files Browse the repository at this point in the history
Removes the studio name from the scene details subtitle since the studio
has a row below.

Also changes the studio row to use the singular "Studio" instead of
plural.

Dev: renames `DetailsDescriptionPresenter` to `SceneDetailsPresenter` so
its clear what its purpose is
  • Loading branch information
damontecres authored Oct 24, 2024
1 parent b614fff commit 4f070e1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ import com.github.damontecres.stashapp.data.Scene
import com.github.damontecres.stashapp.playback.PlaybackActivity
import com.github.damontecres.stashapp.presenters.ActionPresenter
import com.github.damontecres.stashapp.presenters.CreateMarkerActionPresenter
import com.github.damontecres.stashapp.presenters.DetailsDescriptionPresenter
import com.github.damontecres.stashapp.presenters.GalleryPresenter
import com.github.damontecres.stashapp.presenters.GroupPresenter
import com.github.damontecres.stashapp.presenters.MarkerPresenter
import com.github.damontecres.stashapp.presenters.OCounterPresenter
import com.github.damontecres.stashapp.presenters.PerformerInScenePresenter
import com.github.damontecres.stashapp.presenters.SceneDetailsPresenter
import com.github.damontecres.stashapp.presenters.ScenePresenter
import com.github.damontecres.stashapp.presenters.StashPresenter
import com.github.damontecres.stashapp.presenters.StudioPresenter
Expand Down Expand Up @@ -100,6 +100,7 @@ class SceneDetailsFragment : DetailsSupportFragment() {
DataType.STUDIO,
ListRowManager.SparseArrayRowModifier(mAdapter, STUDIO_POS),
mStudioAdapter,
StashApplication.getApplication().getString(DataType.STUDIO.stringId),
) { studioIds ->
val newStudioId =
if (studioIds.isEmpty()) {
Expand Down Expand Up @@ -176,7 +177,7 @@ class SceneDetailsFragment : DetailsSupportFragment() {
private var position = -1L // The position in the video
private val detailsPresenter =
FullWidthDetailsOverviewRowPresenter(
DetailsDescriptionPresenter { rating100: Int ->
SceneDetailsPresenter { rating100: Int ->
viewLifecycleOwner.lifecycleScope.launch(
StashCoroutineExceptionHandler(
Toast.makeText(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import com.github.damontecres.stashapp.views.parseTimeToString
/**
* [AbstractDetailsDescriptionPresenter] for [com.github.damontecres.stashapp.SceneDetailsFragment]
*/
class DetailsDescriptionPresenter(val ratingCallback: StashRatingBar.RatingCallback) :
class SceneDetailsPresenter(val ratingCallback: StashRatingBar.RatingCallback) :
AbstractDetailsDescriptionPresenter() {
override fun onBindDescription(
viewHolder: ViewHolder,
Expand Down Expand Up @@ -57,7 +57,6 @@ class DetailsDescriptionPresenter(val ratingCallback: StashRatingBar.RatingCallb
viewHolder.subtitle.text =
concatIfNotBlank(
" - ",
scene.studio?.studioData?.name,
scene.date,
duration,
resolution,
Expand Down

0 comments on commit 4f070e1

Please sign in to comment.