Exported Restricted Instances show Panel Tabs even if singleInstance

[damiensellier]

Exported Restricted Instances show Panel Tabs even if singleInstance :

[dobo365]

Hmmm... Strange. I don't have this issue. Restricted standalone export with or without menu.
5.6.30.1G built on PC.
Maybe a Mac issue?

[damiensellier]

@dobo365 it's coming from the mods we did recently for 5.6.31 to get the close button on tabs back.

I'll fix that, it's an easy one ;)

[damiensellier]

LOOK FOR :

InstanceSingleRestriced

[damiensellier]

It comes from the fact previous Ctrlr versions was not reseting the ctrlrTabBarDepth for exported instances and was left blank. Which meant :

setProperty (Ids::ctrlrTabBarDepth, 0);

This was causing the propertyPane not having tabs on export (top-right side)

To fix the problem I added in CtrlrManagerInstance.cpp L36 :
setProperty (Ids::ctrlrTabBarDepth, 24);

Now I have to set a condition if InstanceSingleRestriced then hide tabs / or setTabBarDepth = 0 in CtrlrDocumentPanel.cpp :

void CtrlrDocumentPanel::activeDocumentChanged()
{
    CtrlrEditor *ed = dynamic_cast <CtrlrEditor*> (getParentComponent());
    if (ed)
    {
        ed->activeCtrlrChanged();
    }
    
    if (getCurrentTabbedComponent()) {
        
        getCurrentTabbedComponent()->setTabBarDepth(owner.getProperty(Ids::ctrlrTabBarDepth)); // Tab height for horizontal bar
        getCurrentTabbedComponent()->getTabbedButtonBar().setMinimumTabScaleFactor(1.0); // Min tab width ratio
        
        TabbedButtonBar &bar = getCurrentTabbedComponent()->getTabbedButtonBar();
        
        for (int i=0; i<bar.getNumTabs(); i++)
        {
            TabBarButton *button = bar.getTabButton (i); // Gets the panel tab button(i)
            
            if (button)
            {
                CtrlrDocumentPanelCloseButton *closeTabButton = new CtrlrDocumentPanelCloseButton("x"); // Added v5.6.30. Brings back the close button for panel tabs
                closeTabButton->addListener (this);
                closeTabButton->setSize(20, 20);
                closeTabButton->getProperties().set ("index", bar.indexOfTabButton(button));
                closeTabButton->setMouseCursor (MouseCursor::PointingHandCursor);
                button->setExtraComponent (closeTabButton, TabBarButton::afterText);
            }
        }
        
    }
}

[dobo365]

Hmmm...Strange as I also have the Tabs Close buttons...
Will look tomorrow to confirm.

[damiensellier]

FIXED on 22.12.2024 for v5.6.31

Unrestricted Instance :

Restricted Instance

CtrlrDocumentPanel.cpp L48

void CtrlrDocumentPanel::activeDocumentChanged()
{
    CtrlrEditor *ed = dynamic_cast <CtrlrEditor*> (getParentComponent());
    if (ed)
    {
        ed->activeCtrlrChanged();
    }
    
    if (getCurrentTabbedComponent()) {
        
        if (owner.getInstanceMode() == InstanceSingleRestriced) // Added v5.6.31. Hides tabs on exported restricted instances
        {
            getCurrentTabbedComponent()->setTabBarDepth(0); // Tab height for horizontal bar
            getCurrentTabbedComponent()->getTabbedButtonBar().setMinimumTabScaleFactor(0); // Min tab width ratio
        }
        else
        {
            getCurrentTabbedComponent()->setTabBarDepth(owner.getProperty(Ids::ctrlrTabBarDepth)); // Tab height for horizontal bar
            getCurrentTabbedComponent()->getTabbedButtonBar().setMinimumTabScaleFactor(1.0); // Min tab width ratio
        }
        
        TabbedButtonBar &bar = getCurrentTabbedComponent()->getTabbedButtonBar();
        
        for (int i=0; i<bar.getNumTabs(); i++)
        {
            TabBarButton *button = bar.getTabButton (i); // Gets the panel tab button(i)
            
            if (button)
            {
                CtrlrDocumentPanelCloseButton *closeTabButton = new CtrlrDocumentPanelCloseButton("x"); // Added v5.6.30. Brings back the close button for panel tabs
                closeTabButton->addListener (this);
                closeTabButton->setSize(20, 20);
                closeTabButton->getProperties().set ("index", bar.indexOfTabButton(button));
                closeTabButton->setMouseCursor (MouseCursor::PointingHandCursor);
                button->setExtraComponent (closeTabButton, TabBarButton::afterText);
            }
        }
        
    }
}

[synthmania67]

this ist the error message of the validation when exporting an instance with version 5.6.31.03a:
TESTING OPEN TIMES:
COLD:
FATAL ERROR: OpenAComponent: result: -3000,0xFFFFF448

[damiensellier]

Strange, it's working on my setup with AU :

[synthmania67]

You have an intel mac, right? I think it´s a problem with Sonoma and these SILICON CPU only, because all older instances don´t work anymore unless you start in Rosetta mode. But this is not the solution. Developing a working CTRLR instance needs a Silicon Mac.

[damiensellier]

Sorry mate, this is where I have to close the helpdesk :) I already spent 5 hours of my Sunday to fix issues.

For this one, unfortunately I don't have a M4 and Sonoma yet so I can't help.

The only thing I can tell is from now on, AU will validate on mac intel or apple silicon prior Sonoma.

Since on your side you have all the setup, you can try run the AU on debug mode and see where it catches errors with breakpoints.

Good luck

Damien

[synthmania67]

Sonoma changes everything. Most users always make the same mistake: as soon as Apple releases a new operating system, everyone rushes to install it without thinking.
Then, when nothing works, the developers of the software are berated.
That's the only reason I installed Sonoma in the first place. With Ventura, everything still worked perfectly...I don't want to know what doesn't work with Sequoia.
I'm slowly getting fed up with Apple...

Thank you very much for your help. Wish you a Merry Christmas.

[damiensellier]

Yep, most plugin dev have big trouble moving to the next macOS because of that. Apple is never on point with new releases; I'm always 2 versions late to be sure it's 100% working.

I posted about your problem on the JUCE forum. People are relly up to date and knowledgeable there since many top tier plugin dev studios use JUCE. Someone asked a Stack Trace log of your plugin/app crashing. If you could provide it could help.
https://forum.juce.com/t/plugin-and-standalone-apps-crashing-on-sonoma-when-closing/64713/2

Merry Xmas and enjoy your holidays mate.
Take care
Damien

[synthmania67]

Hi Damien, this is the crash report of the standalone app with SONOMA:

[damiensellier]

@synthmania67 thanks! Can you post the /Volumes/Elements.crash and the ctrlrx.crash ?