fix basic ThanosRuler e2e test

The test was producing a nil pointer due to the replicas field not being set.
damienleger · Feb 4, 2020 · e92f260 · e92f260
1 parent 58e96ae
commit e92f260
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/e2e/thanosruler_test.go b/test/e2e/thanosruler_test.go
@@ -27,7 +27,7 @@ func testTRCreateDeleteCluster(t *testing.T) {
 
 	name := "test"
 
-	if _, err := framework.CreateThanosRulerAndWaitUntilReady(ns, framework.MakeBasicThanosRuler(name)); err != nil {
+	if _, err := framework.CreateThanosRulerAndWaitUntilReady(ns, framework.MakeBasicThanosRuler(name, 1)); err != nil {
 		t.Fatal(err)
 	}
 

diff --git a/test/framework/thanosruler.go b/test/framework/thanosruler.go
@@ -26,12 +26,13 @@ import (
 	"github.com/pkg/errors"
 )
 
-func (f *Framework) MakeBasicThanosRuler(name string) *monitoringv1.ThanosRuler {
+func (f *Framework) MakeBasicThanosRuler(name string, replicas int32) *monitoringv1.ThanosRuler {
 	return &monitoringv1.ThanosRuler{
 		ObjectMeta: metav1.ObjectMeta{
 			Name: name,
 		},
 		Spec: monitoringv1.ThanosRulerSpec{
+			Replicas:       &replicas,
 			QueryEndpoints: []string{"test"},
 			LogLevel:       "debug",
 		},