Skip to content

Conversation

@Zentreax
Copy link
Contributor

@Zentreax Zentreax commented Oct 7, 2021

Hey! 👋

In this PR i adressed issue #12.

I added PHP opening tags for every file but "embed_responsive_16_to_9_videos.php" because I don't know if the CSS should be commented out or not.

I also didn't add closing tags:
"If a file contains only PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script. "
(source: https://www.php.net/manual/en/language.basic-syntax.phptags.php)

Would be great if you can accept this for hacktoberfest ;)

  • Zentreax

@Zentreax
Copy link
Contributor Author

Zentreax commented Oct 7, 2021

And can you label my PR as 'hacktoberfest-accepted' please? Since this repository as a whole isn't participating in hacktoberfest.

Copy link
Owner

@dalenguyen dalenguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Zentreax!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants