Skip to content

Spanish documentation done #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 6, 2018
Merged

Spanish documentation done #435

merged 6 commits into from
Oct 6, 2018

Conversation

luisejrobles
Copy link
Contributor

@luisejrobles luisejrobles commented Oct 4, 2018

**What kind of change does this PR introduce?
Docs update ... README translated to spanish

What is the current behavior? (You can also link to an open issue here)
#430 Spanish documentation

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

@dalelotts
Copy link
Owner

Thanks for the PR! Nice work! Can I ask for a change before I merge this?

Can you please split the Spanish and English files? I think the way to do this is to create a new readme.es_MX.md (for Mexican Spanish) and then add a link to the existing readme.md to link to the new readme.es_MX.md?

@luisejrobles
Copy link
Contributor Author

was a pleasure helping you out and of course ! I'm going to make the changes after I get out from the job

@luisejrobles
Copy link
Contributor Author

@dalelotts just to make sure, you want me to create another readme with the name readme.es_MX.md and put in a link to the us version and viceversa?

@dalelotts
Copy link
Owner

I think linking both directions would be best. Something like this readme.md

@luisejrobles
Copy link
Contributor Author

I'll do it in the night or tomorrow

@luisejrobles
Copy link
Contributor Author

Done @dalelotts 👌

@dalelotts
Copy link
Owner

Looks great! Thank you so much!!

@dalelotts dalelotts merged commit c03327f into dalelotts:develop Oct 6, 2018
@dalelotts
Copy link
Owner

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants