Add #[track_caller] to CtOption::{expect, unwrap}#152
Open
tarcieri wants to merge 1 commit intodalek-cryptography:developfrom
Open
Add #[track_caller] to CtOption::{expect, unwrap}#152tarcieri wants to merge 1 commit intodalek-cryptography:developfrom
#[track_caller] to CtOption::{expect, unwrap}#152tarcieri wants to merge 1 commit intodalek-cryptography:developfrom
Conversation
This option adds a location hint about the function which called it, which is useful when debugging panics since otherwise unless you set `RUST_BACKTRACE` you instead get the line in `subtle` where a particular `assert!` failed, rather than the location of the call site into `expect` or `unwrap`. See: https://doc.rust-lang.org/reference/attributes/codegen.html#the-track_caller-attribute
Contributor
Author
|
Well this is unfortunate: I can add this change to #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option adds a location hint about the function which called it, which is useful when debugging panics since otherwise unless you set
RUST_BACKTRACEyou instead get the line insubtlewhere a particularassert!failed, rather than the location of the call site intoexpectorunwrap.See: https://doc.rust-lang.org/reference/attributes/codegen.html#the-track_caller-attribute
Closes #142