New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`parsed-smile-seq` actually parses JSON #175

Open

nilern opened this issue Mar 18, 2021 · 0 comments · May be fixed by #176

Contributor

nilern commented Mar 18, 2021

Note on using non-byte-based sources/targets (char based, like Reader and Writer): these can not be used for Smile-format documents, and thus will either downgrade to textual JSON (when parsing), or throw exception (when trying to create generator).

https://javadoc.io/doc/com.fasterxml.jackson.dataformat/jackson-dataformat-smile/latest/com/fasterxml/jackson/dataformat/smile/SmileFactory.html

Looks like parsed-smile-seq should take an InputStream instead. That would fix the bug but is a breaking change.

The text was updated successfully, but these errors were encountered:

nilern added a commit to nilern/cheshire that referenced this issue


          Fix dakrone#175 (SMILE Reader)

ac54f61

nilern linked a pull request

that will close this issue

Create parsers via protocols #176

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment