Skip to content

Comments

Add fully specified algorithms#612

Merged
dajiaji merged 8 commits intomainfrom
add-fully-specified-algorithms
Jul 20, 2025
Merged

Add fully specified algorithms#612
dajiaji merged 8 commits intomainfrom
add-fully-specified-algorithms

Conversation

@kentakayama
Copy link
Collaborator

Adds

  • ESP256, ESP384 and ESP512
  • Ed25519 and Ed448

See their details https://datatracker.ietf.org/doc/html/draft-ietf-jose-fully-specified-algorithms

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (f547b0a) to head (9d61dea).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          32       32           
  Lines        3327     3332    +5     
=======================================
+ Hits         3239     3244    +5     
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kentakayama
Copy link
Collaborator Author

kentakayama commented Jul 1, 2025

Since ES256 (-7), ES384 (-35), ES512 (-36) and EdDSA (-8) will be Deprecated by draft-ietf-jose-fully-specified-algorithms, selecting fully specified algorithms by default such as ESP256 (-9) for a key with P-256 curve and sign, verify ops would be appropriate.
Please consider modifying the EC2Key and OKPKey behaviors.

@kentakayama kentakayama requested a review from dajiaji July 1, 2025 02:37
Copy link
Owner

@dajiaji dajiaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentakayama Thank you for your contribution! I apologize for the delayed review. It looks good to me.

I’ll add a few more tests on my end, but I’ll go ahead and merge it for now.

@dajiaji dajiaji merged commit 22310bf into main Jul 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants