Angular 17

.github/workflows/npm-publish.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 18
           registry-url: https://registry.npmjs.org/
       - run: npm ci
       - run: npm run build

.github/workflows/test.yml

@@ -15,10 +15,10 @@ jobs:
         with:
           ref: ${{ github.base_ref }}
       - uses: actions/checkout@v2
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 18.x
       - run: npm ci
       - run: npm run build
       - run: npm run test

.gitignore

@@ -39,3 +39,5 @@ testem.log
 Thumbs.db
 
 .angular
+
+.nx/cache

.nvmrc

@@ -1 +1 @@
-16
+18

.prettierignore

@@ -3,3 +3,5 @@
 /dist
 /coverage
 .angular
+
+/.nx/cache

apps/examples-e2e/project.json

@@ -21,11 +21,8 @@
       }
     },
     "lint": {
-      "executor": "@nx/linter:eslint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/examples-e2e/**/*.{js,ts}"]
-      }
+      "executor": "@nx/eslint:lint",
+      "outputs": ["{options.outputFile}"]
     }
   },
   "tags": [],

apps/examples/project.json

@@ -50,39 +50,29 @@
       "executor": "@angular-devkit/build-angular:dev-server",
       "configurations": {
         "production": {
-          "browserTarget": "examples:build:production"
+          "buildTarget": "examples:build:production"
         },
         "development": {
-          "browserTarget": "examples:build:development"
+          "buildTarget": "examples:build:development"
         }
       },
       "defaultConfiguration": "development"
     },
     "extract-i18n": {
       "executor": "@angular-devkit/build-angular:extract-i18n",
       "options": {
-        "browserTarget": "examples:build"
+        "buildTarget": "examples:build"
       }
     },
     "lint": {
-      "executor": "@nx/linter:eslint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/examples/**/*.ts", "apps/examples/**/*.html"]
-      }
+      "executor": "@nx/eslint:lint",
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",
       "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
       "options": {
-        "jestConfig": "apps/examples/jest.config.ts",
-        "passWithNoTests": true
-      },
-      "configurations": {
-        "ci": {
-          "ci": true,
-          "codeCoverage": true
-        }
+        "jestConfig": "apps/examples/jest.config.ts"
       }
     },
     "serve-static": {

apps/examples/src/app/basic-smart-dumb-example/basic-smart/basic-smart.component.spec.ts

@@ -6,6 +6,8 @@ import { Brewery } from '../model/brewery';
 import { RandomBreweryService } from '../random-brewery.service';
 import * as angularCore from '@angular/core';
 
+jest.mock('@angular/core');
+
 describe('BasicSmartComponent', () => {
   function createComponent(): {
     component: BasicSmartComponent;

apps/examples/src/app/multiple-data-sources/container/multiple-sources-container.component.spec.ts

@@ -12,6 +12,8 @@ import {
 } from 'ngx-http-request-state';
 import { HttpErrorResponse } from '@angular/common/http';
 
+jest.mock('@angular/core');
+
 describe('MultipleSourcesContainerComponent', () => {
   function setup(): {
     component: MultipleSourcesContainerComponent;

libs/ngx-http-request-state/.eslintrc.json

@@ -2,6 +2,23 @@
   "extends": ["../../.eslintrc.json"],
   "ignorePatterns": ["!**/*"],
   "overrides": [
+    {
+      "files": "package.json",
+      "parser": "jsonc-eslint-parser",
+      "rules": {
+        "@nx/dependency-checks": [
+          "error",
+          {
+            "ignoredDependencies": ["tslib"],
+            "ignoredFiles": [
+              "**/jest.config.ts",
+              "**/test-setup.ts",
+              "**/*.spec.ts"
+            ]
+          }
+        ]
+      }
+    },
     {
       "files": ["*.ts"],
       "rules": {

libs/ngx-http-request-state/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2021 David Scourfield
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

libs/ngx-http-request-state/README.md

@@ -12,7 +12,8 @@ support its development:
 
 ## Versions
 
-Version `^3.0.0` supports Angular 14, 15 & 16.
+Version `^3.1.0` supports Angular 14 - 17.
+Version `3.0.0` supports Angular 14, 15 & 16.
 Version `^2.1.0` supports Angular 14 & 15.
 Version `1.2.0` supports Angular 8 to 13.
 Angular versions 7 and earlier are not supported.

libs/ngx-http-request-state/ng-package.json

@@ -3,5 +3,6 @@
   "dest": "../../dist/libs/ngx-http-request-state",
   "lib": {
     "entryFile": "src/index.ts"
-  }
+  },
+  "assets": ["LICENSE"]
 }

libs/ngx-http-request-state/package.json

@@ -9,11 +9,10 @@
     "loading",
     "error"
   ],
-  "version": "3.0.0",
+  "version": "3.1.0",
   "peerDependencies": {
     "rxjs": "^6.2.0 || ^7.4.0",
-    "@angular/common": "^14.2.10 || ^15.0.1 || ^16.0.0",
-    "@angular/core": "^14.2.10 || ^15.0.1 || ^16.0.0"
+    "@angular/common": "^14.2.10 || ^15.0.1 || ^16.0.0 || ^17.0.0"
   },
   "dependencies": {
     "tslib": "^2.3.0"

libs/ngx-http-request-state/project.json

@@ -10,8 +10,7 @@
       "executor": "@nx/angular:package",
       "outputs": ["{workspaceRoot}/dist/{projectRoot}"],
       "options": {
-        "project": "libs/ngx-http-request-state/ng-package.json",
-        "updateBuildableProjectDepsInPackageJson": false
+        "project": "libs/ngx-http-request-state/ng-package.json"
       },
       "configurations": {
         "production": {
@@ -24,27 +23,14 @@
       "defaultConfiguration": "production"
     },
     "lint": {
-      "executor": "@nx/linter:eslint",
-      "options": {
-        "lintFilePatterns": [
-          "libs/ngx-http-request-state/src/**/*.ts",
-          "libs/ngx-http-request-state/src/**/*.html"
-        ]
-      },
+      "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",
       "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
       "options": {
-        "jestConfig": "libs/ngx-http-request-state/jest.config.ts",
-        "passWithNoTests": true
-      },
-      "configurations": {
-        "ci": {
-          "ci": true,
-          "codeCoverage": true
-        }
+        "jestConfig": "libs/ngx-http-request-state/jest.config.ts"
       }
     }
   }

libs/ngx-http-request-state/src/lib/builders.ts

@@ -6,6 +6,7 @@ import { HttpErrorResponse } from '@angular/common/http';
  *
  * @param value may be provided to indicate the previously-loaded, or last-known, state
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const loadingState = <T = any>(value?: T): LoadingState<T> => ({
   isLoading: true,
   value,
@@ -29,6 +30,7 @@ export const loadedState = <T>(value: T): LoadedState<T> => ({
  * @param error
  * @param value may be provided to indicate the previously-loaded, or last-known, state
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const errorState = <T = any>(
   error: HttpErrorResponse | Error,
   value?: T

nx.json

@@ -3,14 +3,6 @@
   "affected": {
     "defaultBase": "origin/main"
   },
-  "tasksRunnerOptions": {
-    "default": {
-      "runner": "nx/tasks-runners/default",
-      "options": {
-        "cacheableOperations": ["build", "lint", "test", "e2e"]
-      }
-    }
-  },
   "generators": {
     "@nx/angular:application": {
       "style": "css",
@@ -29,21 +21,34 @@
   },
   "targetDefaults": {
     "e2e": {
-      "inputs": ["default", "^production"]
-    },
-    "test": {
-      "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"]
+      "inputs": ["default", "^production"],
+      "cache": true
     },
     "lint": {
       "inputs": [
         "default",
         "{workspaceRoot}/.eslintrc.json",
         "{workspaceRoot}/.eslintignore"
-      ]
+      ],
+      "cache": true
     },
     "build": {
       "dependsOn": ["^build"],
-      "inputs": ["production", "^production"]
+      "inputs": ["production", "^production"],
+      "cache": true
+    },
+    "@nx/jest:jest": {
+      "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"],
+      "cache": true,
+      "options": {
+        "passWithNoTests": true
+      },
+      "configurations": {
+        "ci": {
+          "ci": true,
+          "codeCoverage": true
+        }
+      }
     }
   },
   "namedInputs": {
@@ -53,7 +58,8 @@
       "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
       "!{projectRoot}/tsconfig.spec.json",
       "!{projectRoot}/jest.config.[jt]s",
-      "!{projectRoot}/.eslintrc.json"
+      "!{projectRoot}/.eslintrc.json",
+      "!{projectRoot}/src/test-setup.[jt]s"
     ],
     "sharedGlobals": []
   }