SwipeLayout: Allow childs to deny swipe gesture #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with ScorllView(or horizontal) inside SwipeLayout, the swipe gesture may conflict with the scroll action. If use requestDisallowInterceptTouchEvent, the scroll action will be back but the parent ListView's scroll action may be disallowed too. This patch solved this problem by introducing a "SwipeDenier" interface whose implementation should return if this swipe event should be denied. When onInterceptTouchEvent is called, SwipeLayout will call all SwipeDenier and if one of them returns true, the event will not be intercepted and passed to child views. Tested in app: https://github.com/PaperAirplane-Dev-Team/BlackLight which requires HorizontalScrollView inside SwipeLayout Signed-off-by: Peter Cai <xqsx43cxy@126.com>
daimajia
added a commit
that referenced
this pull request
Aug 29, 2014
SwipeLayout: Allow childs to deny swipe gesture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with ScorllView(or horizontal) inside SwipeLayout, the swipe
gesture may conflict with the scroll action. If use requestDisallowInterceptTouchEvent, the scroll action will be back but the parent ListView's scroll action may be disallowed too.
This patch solved this problem by introducing a "SwipeDenier"
interface whose implementation should return if this swipe event should
be denied. When onInterceptTouchEvent is called, SwipeLayout will call
all SwipeDenier and if one of them returns true, the event will not be
intercepted and passed to child views.
Tested in app: https://github.com/PaperAirplane-Dev-Team/BlackLight
which requires HorizontalScrollView inside SwipeLayout
Signed-off-by: Peter Cai xqsx43cxy@126.com