Dailymotion Bid Adapter: add consent enforcement to read the advertising cookie #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently testing these changes into the E2E framework to validate they work with a standard Prebid.js deployment and a third party video player. |
|
This feature can't be tested E2E without a full CMP implementation, which we don't currently have in testing environment. But we managed to test it by hardcoding the consent values (extracted from Dailymotion CMP) in this E2E PR. Please note that because of this known issue in Prebid 9.4.0, we could not validate with the official latest version, but it was confirmed to:
So we can now merge this change as soon as it's reviewed. |
kvnsw
force-pushed
the
cookie_reading_consent_enforcement
branch
from
77f585c
to
4aeb8a8
Compare
kvnsw
approved these changes
Jul 9, 2024
|
Reviewed:
|
…ing cookie * [x] Feature * Add consent enforcement before reading the advertising cookie * If Dailymotion does not have consent from the user, it does not transmit any cookie in the request to the Prebid server (previously the cookie was sent but not used)
kvnsw
force-pushed
the
cookie_reading_consent_enforcement
branch
from
4aeb8a8
to
a099bf0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change