Repository navigation
fix(messages): show inbox rows before the chat history loads - #6867
Merged
Merged
Conversation
The inbox stayed on skeletons until the chat socket was up and one archive lookup per conversation had finished (the chat server answers those one at a time, and a slow one can hold the list for up to 10s). The API already knows who each conversation is with and the unread count, so show those rows, openable, while the last messages load.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rebelchris
marked this pull request as ready for review
October 12, 2026 09:49
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Promise.allSettledwaits for the slowest. Before any of that, the strophe chunk and token load only after the page mounts.dmConversationPeersQueryOptions(the API list only: peer and unread count, one request) and renders those rows, openable andaria-busy, while the full inbox loads. The rows switch to last-message previews when the history arrives.ConversationList.spec.tsxcovers rows while pending and the swap to previews. Allfeatures/messagestests pass.Known trade-offs / follow-ups:
listConversations). It is cheap; folding it into one needs a transport interface change.lastMessageAt+ preview onDirectMessageConversation.markDirectMessageSentalready receives the preview. Then the inbox needs no MAM lookups at all, and opening a thread on page load stops queueing behind them.Events
No
Experiment
No
🤖 Investigated and drafted by Smith (AI) for @rebelchris.
Preview domain
https://fix-dm-inbox-show-rows-early.preview.app.daily.dev