Repository navigation
fix(feeds): restore feed settings sidebar width on tablet and up - #6840
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #6767, the create/edit feed modal is broken on tablet and desktop. The left menu shrinks to bare chevrons, the settings pane is pushed to the far right, and the modal scrolls sideways (reported in ENG-2213).
Cause
#6767 changed the sidebar class from
w-74totablet:w-74 w-full. There is no74width in our Tailwind config (only70and76), sotablet:w-74produces no CSS. That leavesw-fullactive at every width, so the nav fills the whole modal.Fix
w-full bg-transparent tablet:w-autoisMobilebranch,ViewSize.MobileL): stillw-full, so the intended mobile behaviour from feat(mobile): the phone shell #6767 is unchanged.w-auto, which is what the old no-opw-74effectively gave us. The menu sizes to its content again.This PR was opened by Smith (AI assistant) on behalf of @rebelchris.
Preview domain
https://fix-feed-settings-sidebar-width.preview.app.daily.dev