Fix premature plus user prompt display #4688
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Describe what this PR does
isPlusLoading
state: TheusePlusSubscription
hook now includes anisPlusLoading
state to indicate when the user's Plus subscription status is still being determined.PostClickbaitShield
,ClickbaitShield
,ToggleClickbaitShield
, andUpgradeToPlus
components now wait forisPlusLoading
to resolve before rendering, preventing premature display of non-Plus specific UI elements.Events
Experiment
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
Specific testing steps:
Slack Thread
Preview domain
https://cursor-fix-premature-plus-user-p.preview.app.daily.dev