Skip to content

Fix premature plus user prompt display #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idoshamun
Copy link
Member

@idoshamun idoshamun commented Jul 15, 2025

Changes

Describe what this PR does

  • Fixes UI flicker for Plus users: Resolves an issue where the "This title could be cleaner..." prompt briefly appeared for Plus users on post page load.
  • Introduces isPlusLoading state: The usePlusSubscription hook now includes an isPlusLoading state to indicate when the user's Plus subscription status is still being determined.
  • Ensures correct rendering: PostClickbaitShield, ClickbaitShield, ToggleClickbaitShield, and UpgradeToPlus components now wait for isPlusLoading to resolve before rendering, preventing premature display of non-Plus specific UI elements.

Events

Experiment

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

Specific testing steps:

  1. As a Plus user: Load a post page and confirm no "This title could be cleaner..." prompt appears, even briefly.
  2. As a non-Plus user: Confirm the "This title could be cleaner..." prompt still appears as expected.
  3. Network throttling: Test with a slow network connection to ensure no flicker occurs during loading for either Plus or non-Plus users.

Slack Thread

Preview domain

https://cursor-fix-premature-plus-user-p.preview.app.daily.dev

Co-authored-by: ido <ido@daily.dev>
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jul 15, 2025 8:09am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jul 15, 2025 8:09am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants