chore: ActiveMq cleanup and completion #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hnogared
added
state:ready for merge
Hnogared
force-pushed
the
chore/activemq-cleanup
branch
from
2b32e70 to
5443fc3
Compare
Hnogared
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #708 +/- ##
============================================
Coverage 97.71% 97.71%
============================================
Files 104 104
Lines 1794 1796 +2
Branches 317 318 +1
============================================
+ Hits 1753 1755 +2
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samtrion
approved these changes
May 24, 2025
Hnogared
force-pushed
the
chore/activemq-cleanup
branch
from
85081be to
81076df
Compare
|
samtrion
pushed a commit
that referenced
this pull request
May 26, 2025
* test: Added client factory tests * chore: Added configure timeout validation * chore: Renamed `ActiveMq` checks files * test: Added `ActiveMq` integration tests * chore(ActiveMq): Using const instead of var for local variables * chore(Redpanda): Use const for local variables * chore(Firebird): Use const for local variables * chore(ServiceBus): Use const for local variables
samtrion
added a commit
that referenced
this pull request
May 26, 2025
* feat: Added AWS SNS package (#573) * feat: Azure ServiceBus package (#559) * feat: Azure CosmosDB package (#562) * fix(style): Formatting of new project files * fix: Use same version for all testcontainers * fix(style): Reformatted code with line length 120 * fix(deps): Updated Dependency `Apache.NMS.ActiveMQ` because of possible vulnerability * chore: Updated TestGroups * fix: Missing namespaces * fix: Added `AWS.SNS` as TestGroup * chore: Cleanup SNS * chore: Cleanup ActiveMq * chore(deps): Updated new packages * chore: Added TestGroup `Azure.ServiceBus` * chore: Extended Tests for `AWS.SNS` and `Azure.ServiceBus` * chore: Extended the tests for `AWS.SNS` * chore: Added Validation for `SimpleNotificationService` * fix: Removed braces * fix: Raised `GitVersionTargetFramework` * chore: Extended AWS SNS tests * fix: Added missing xml documentations * chore: Extended `SimpleNotificationServiceConfigure` tests * feat: Added first Implementation for `Azrue.Cosmos` * chore: Removed unnecessary namespaces * fix: Cosmos tests * fix: Switched to `records` as options * fix(test): Fixed tests for Azure blobs, queues and tables * chore: Set reference to `NetEvolve.HealthChecks.Azure.Cosmos` * feat(firebird): Added `NetEvolve.HealthChecks.Firebird` (#707) * feat(firebird): aded firebird checks * docs: corrected therefore into therefore * fix: review findings * fix(warnings): Removed warnings from code * fix(test): Updated PublicApi definitions * fix(test): Added missing testcase for `HealthCheckBase` * fix(docs): Added missing xml docs to `ServiceBus.ClientCreationMode` * chore: Removed CosmosDb implementation for now, because container not executable * fix(docs): Updated the mentioned method * chore: Extended `AWS.SNS` tests * fix(tests): Added missing validation for `Timeout` * test: Extended `Azure.ServiceBus` Tests * fix(test): Missing testcase `Azure.ServiceBus.ClientCreation` * test: Finished the `Azure.ServiceBus` tests * chore: ActiveMq cleanup and completion (#708) * test: Added client factory tests * chore: Added configure timeout validation * chore: Renamed `ActiveMq` checks files * test: Added `ActiveMq` integration tests * chore(ActiveMq): Using const instead of var for local variables * chore(Redpanda): Use const for local variables * chore(Firebird): Use const for local variables * chore(ServiceBus): Use const for local variables * chore(Apache.Kafka): Use const for local variables * chore(Apache.ActiveMq): Use const for local variable * test(Apache.ActiveMq): Changed unhealthy test to not use a valid URI * test(abstractions): Extended tests for `IHealthChecksBuilderExtensions` * chore: Added build target `EnsureREADME` for all healthcheck projects * style(format): Reformatted code * chore: Use expression body lambdas * chore: Use const for named test parameters * style: Minimized styles and reduced overhead * style: Minimized styles and reduced overhead, again * test(sns): Extended tests * fix(test): Updated public api * fix(nameof): Use `nameof` instead of `.ToString()` * test(servicebus): Extended tests * test(servicebus): Extended unit tests for Azure.ServiceBus * docs(qdrant): Added missing README * chore: Updated Naming for Azure.ServiceBus * docs(activemq): Updated README file for `Apache.ActiveMq` * chore: Removed unused `_snapshots` * chore: Simplified tests * docs(sns): Updated README * fix: Default tags for messaging services * docs(servicebus): Updated README * style(docs): Reformatted README files * fix(docs): Renamed README.md Signed-off-by: Martin Stühmer <me@samtrion.net> * test: Extended `ConfigurableHealthCheckBase` tests * test: Extended Architecture tests * chore(test): Updated the changes to the verify files * fix: Solved PR findings * fix(servicebus): Simplified access to container --------- Signed-off-by: Martin Stühmer <me@samtrion.net> Co-authored-by: Hnogared <133124217+Hnogared@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for the client factory.
Added timeout check in the configure validation.
Renamed ActiveMq checks files.
Added more ActiveMq integration tests.