Skip to content

Conversation

@matthewyang204
Copy link
Contributor

@matthewyang204 matthewyang204 commented Jan 11, 2026

Changes:

  1. Rename the Find in Files button to Replace in Files because Find in Files is 1. pretty useless 2. too hard to implement (unless someone else wants to do so)
  2. Build a Replace in Files where the user can replace stuff in a directory of their choice recursively

Please check that you like it, and then make any changes you want. Otherwise, feel free to merge. Also, given the number of commits, you may not want to squash the entire thing into one patch

Sorry, I renamed the branch which caused #906 to close. I've reopened it here.

@dail8859 dail8859 merged commit 2af96ee into dail8859:master Jan 11, 2026
24 checks passed
@dail8859
Copy link
Owner

My apologies. I was reviewing this and did not mean to merge it.

The part that I do not like about this PR is that it does not use any of the underlying functionality (regex...which I know does not work great, extended mode, match case, whole word only, etc) which will cause confusion to users expecting it to work exactly the same as the normal replace functionality to files that are opened.

@matthewyang204
Copy link
Contributor Author

We can always fix it though, thanks for feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants