Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Flux Bidder Adapter #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

daikichiteranishi
Copy link
Owner

@daikichiteranishi daikichiteranishi commented Jul 29, 2021

日本語の説明

prebid公式でマージリクエストを出すときはここは消します。
これをマージ後、prebid公式にマージリクエストを出します。

Jira

ALD-2160

主な作業内容

prebid#4439
prebid#4908

上のプルリクでの作業内容を参考にアダプターを生成しました。
ただし、一部の箇所はテストが落ちたので書き方を変えました。
また、spec jsは古い物だとテスト通らない&網羅率が低かったので全体的に書き換えました。

確認項目

テストページ
https://another.geniee.jp/test/teranishi/prebid/flux/test.html
テスト枠
https://geniee.slack.com/archives/C012H38442D/p1628648842119100?thread_ts=1627953199.041100&cid=C012H38442D

  • gulp test --file "test/spec/modules/fluxBidAdapter_spec.js" でテストが通ることを確認しました

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'AdCurrent',
  params: {
    placementId: 1234567, // required, integer
    currency: 'JPY' // optional, JPY or USD is valid
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant