Clamp system coolant request to 100% when using autocoolant #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autocoolant behavior is inconsistent when max coolant exceeds the default of 10 (equal to max_coolant_per_system). Coolant requests would exceed 100% of max_coolant_per_system, and capping the request to max_coolant_per_system would distribute the remaining coolant inefficiently. Instead, track the ideal request amounts, then modify them to fit within the limits while redistributing the excess coolant to other systems in need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocoolant behavior is inconsistent when max coolant exceeds the default of 10 (equal to
max_coolant_per_system). Coolant requests would exceed 100% ofmax_coolant_per_system, and capping the request tomax_coolant_per_systemwould distribute the remaining coolant inefficiently.Instead, track the ideal request amounts, then modify them to fit within the limits while redistributing the excess coolant to other systems in need.
Should fix #2563.