Refactor GuiResizableDialog and GameMasterChatDialog #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oznogon
force-pushed
the
2551-refactor-resizabledialog-gm-chat
branch
5 times, most recently
from
8a0f451 to
0dda3ef
Compare
- Use rotating icon for minimize GuiToggleButton - Use layout properties instead of absolute positioning - Use GuiAutoSizeLabel for title bar and clip overflow title text
oznogon
force-pushed
the
2551-refactor-resizabledialog-gm-chat
branch
from
0dda3ef to
1015277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor GuiResizableDialog and GameMasterChatDialog to use layout properties instead of absolutely positioned and sized elements.
This PR also:
Depends on #2556 (for minimize icon) and #2557 (for clipping title text). Supports #2551.
Before:
After: