[#2466] Hack GuiSelector popup fix using string IDs

[oznogon]

Attempt to work around #2466 by assigning string IDs to popups generated by clicking a GuiSelector, then iterating through children of CrewStationScreen and hiding them when changing tabs.

[daid]

I see how it fixes this specific instance of the problem, but I don't like the hackyness of the solution.

I wonder if somehow the loss of focus on the selector could be used to hide this, as I'm quite sure it will get focus as soon as you open the popup, and loses focus as soon as you click something else.

[oznogon]

I see how it fixes this specific instance of the problem, but I don't like the hackyness of the solution.

I don't like this solution either, but the popup implementation itself is hacky for being parented to the highest-level UI element.

I wonder if somehow the loss of focus on the selector could be used to hide this, as I'm quite sure it will get focus as soon as you open the popup, and loses focus as soon as you click something else.

I had experimented with implementing GuiSelector::onFocusLost() { popup->hide() } before coming to this solution, but onFocusLost() doesn't trigger when the crew screen is changed via keybind.

[daid]

Beh, yeah, I see why that happens. The whole thing is a bit annoying. Also with the knowledge that in SP2 each widget does know if it is visible or not, while in EE-gui this is implicit. With the focus lost, it does then disappear as soon as you click something else I assume?

[oznogon]

With the focus lost, it does then disappear as soon as you click something else I assume?

No. Even if I click something else, the popup persists until I return to the crew screen containing the selector that created the popup.

If I have clicked something else on a different crew screen, the popup disappears only after I return to the originating crew screen.

If I haven't clicked something else on a different crew screen and then return to the originating crew screen, the popup persists until I click on something else on the originating crew screen.

---

I've reverted the string check and tried again with GuiSelector::onFocusLost() { popup->hide() } , this time also setting focus(main_panel) in CrewStationScreen::showTab() to force a focus change as if clicked. This seems to work.

[daid]

Feels like a bit cleaner solution. Still a bit hacky, and possibly some edge cases where you can have a stuck popup. But better then nothing.