Upgrade and add some opinionated stuff #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichirata
reviewed
Feb 3, 2024
| @@ -1,15 +1,25 @@ | |||
| FROM debian:buster-slim AS build | |||
| FROM golang:1.21 as builder | |||
Owner
There was a problem hiding this comment.
Thank you so much for the improvements to the Docker files!
I agree with the use of distroless images, but I think it would be less problematic and more beneficial to download binaries generated by github actions rather than have users build the executables themselves, which would speed up the image generation. What do you think?
Author
There was a problem hiding this comment.
Sure, I agree, I'll change ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all, thanks for your work, this project is awesome!
I've upgraded all the dependencies because I just begun to use it.
I also made a couple of changes that could be considered opinionated, so if you don't want those, I'll revert them, no problem.
One is build statically. The other is use distroless for docker container, which is supposed to be more secure.
Anyway, let me see what you think and let's go from them
Thanks again!