feat(router): props inferred for page components #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
force-pushed
the
feat/page-props
branch
from
0eada98
to
ea07eb0
Compare
tylersayshi
commented
Sep 29, 2024
tylersayshi
force-pushed
the
feat/page-props
branch
from
1c908ea
to
8129ac0
Compare
|
@dai-shi do you have recommendations for which docs to update for this change and which examples are updated to use this? |
dai-shi
reviewed
Sep 29, 2024
tylersayshi
force-pushed
the
feat/page-props
branch
from
eef4276
to
697d180
Compare
dai-shi
reviewed
Sep 29, 2024
tylersayshi
force-pushed
the
feat/page-props
branch
from
697d180
to
e80fd55
Compare
tylersayshi
force-pushed
the
feat/page-props
branch
from
e80fd55
to
1ca68dd
Compare
dai-shi
reviewed
Sep 29, 2024
dai-shi
reviewed
Sep 30, 2024
|
Yep! @dai-shi |
dai-shi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to move things around as needed :)
This change adds the Page component prop support