Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: private dir hmr #675

Merged
merged 4 commits into from
Apr 27, 2024
Merged

fix: private dir hmr #675

merged 4 commits into from
Apr 27, 2024

Conversation

Aslemammad
Copy link
Contributor

Resolves #592

We did not react to changes in the private dir.

Since we're sure they're server only, let's treat them as rsc updates, so the changes get reflected on the client.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 26, 2024 11:26pm

Copy link

codesandbox-ci bot commented Apr 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dai-shi dai-shi mentioned this pull request Apr 26, 2024
86 tasks
@dai-shi dai-shi merged commit 182c162 into dai-shi:main Apr 27, 2024
28 checks passed
@Aslemammad Aslemammad deleted the fix/private-hmr branch April 27, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support listening to private directory for changes and trigger RSC hot reload
2 participants