Removed lifetime from transaction

[rakshith-ravi]

Transactions don't really require a lifetime anyway, since Client can be cloned easily. This would make the API surface simpler and make it easier to use a Transaction as a struct field, in order to pass it as state to functions

[rakshith-ravi]

I was able to run the tests, but certain tests seem to fail, and I'm honestly not sure why. So any help on that would be appreciated

[mcatanzariti]

Hi @rakshith-ravi

Thank you for your contribution!
Can you please undo changes on docker compose and dockerfiles from the PR?

Cheers,

Michaël

[rakshith-ravi]

Hi Michaël,

The changes on the PR for the Dockerfiles are intentional. The permissions on the files have been changed to 755 themselves, which would remove the need for setting permissions on the Dockerfile. One of the reasons that I did this was because older version of docker (specifically, I'm running the latest docker engine supported by Ubuntu LTS) does not support the --chmod directive.

As for docker compose -> docker-compose, a lot of distros (again, I'm running the latest supported by Ubuntu LTS - Maybe it's time to shift to NixOS?) ship older versions of compose, which is a separate command (docker-compose) instead of the new compose, which is a sub-command of docker. However, do note from here: https://docs.docker.com/compose/migrate/#what-does-this-mean-for-my-projects-that-use-compose-v1

However, Docker Desktop continues to support a docker-compose alias to redirect commands to docker compose for convenience and improved compatibility with third-party tools and scripts

This should ideally mean that docker-compose should work for both older and newer users.

Hope this helps.

Regards,
Rakshith Ravi

[mcatanzariti]

Hi @rakshith-ravi,

Fair enough!
In this case it should be part of an initial and separated PR

Cheers,

Michaël

[rakshith-ravi]

Ahh, right. That makes sense. I'll rebase this PR and push the other changes separately :D

[rakshith-ravi]

Yup. Rebased. I'll open a subsequent PR that will be on top of this

[rakshith-ravi]

Hi @mcatanzariti. Did you get a chance to take a look at this PR?

[mcatanzariti]

Not yet, sorry.
I have to find time to fix automated tests firsts