Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#831] cmd: fix: --config parameter handling #834

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Feb 13, 2025

Issue: #831

Changes

  • Fixed the bug in --config parameter handling
  • Added tests for --config parameter

@yohamta yohamta merged commit bbff142 into main Feb 13, 2025
4 checks passed
@yohamta yohamta deleted the 831-fix-config-param branch February 13, 2025 09:37
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 82.89474% with 26 lines in your changes missing coverage. Please review.

Project coverage is 55.94%. Comparing base (11f4649) to head (c6d06b1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/loader.go 37.50% 8 Missing and 2 partials ⚠️
cmd/config.go 73.91% 4 Missing and 2 partials ⚠️
cmd/restart.go 81.81% 1 Missing and 1 partial ⚠️
cmd/retry.go 86.66% 1 Missing and 1 partial ⚠️
cmd/start.go 83.33% 1 Missing and 1 partial ⚠️
internal/config/config.go 0.00% 2 Missing ⚠️
cmd/dry.go 92.30% 0 Missing and 1 partial ⚠️
cmd/server.go 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   55.73%   55.94%   +0.20%     
==========================================
  Files          74       75       +1     
  Lines        8108     8096      -12     
==========================================
+ Hits         4519     4529      +10     
+ Misses       3202     3172      -30     
- Partials      387      395       +8     
Files with missing lines Coverage Δ
cmd/main.go 78.94% <ø> (+2.28%) ⬆️
cmd/scheduler.go 59.37% <100.00%> (-4.73%) ⬇️
cmd/setup.go 76.68% <100.00%> (+1.55%) ⬆️
cmd/startall.go 52.45% <100.00%> (ø)
cmd/status.go 59.45% <100.00%> (+3.57%) ⬆️
cmd/stop.go 59.45% <100.00%> (+3.57%) ⬆️
internal/scheduler/manager.go 68.42% <100.00%> (+0.27%) ⬆️
internal/scheduler/scheduler.go 68.75% <100.00%> (+0.24%) ⬆️
cmd/dry.go 69.23% <92.30%> (+1.23%) ⬆️
cmd/server.go 83.01% <96.15%> (+2.71%) ⬆️
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f4649...c6d06b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant