[4/n] [RFC] add launch multiple runs backend functionality #25880
Conversation
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7e104b4. |
dliu27
changed the title
js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
Outdated
Show resolved
Hide resolved
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
9e8213d
to
4406df6
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
db05f4b
to
7e104b4
Compare
| @@ -73,17 +74,22 @@ class Meta: | |||
|
|
|||
| class GrapheneLaunchRunResult(graphene.Union): | |||
| class Meta: | |||
| from dagster_graphql.schema.backfill import pipeline_execution_error_types | |||
There was a problem hiding this comment.
and why was it there in the first place 🤔
| for run_id in run_ids: | ||
| result = execute_dagster_graphql( | ||
| context=graphql_context, query=RUN_QUERY, variables={"runId": run_id} | ||
| ) | ||
| assert result.data["pipelineRunOrError"]["__typename"] == "Run" | ||
| assert result.data["pipelineRunOrError"]["status"] == "SUCCESS" |
There was a problem hiding this comment.
not sure we need this? I guess it's just asserting that the runs would have succeeded also if they were run individually but I think we can just assume that is the case given the mock setup.
| name = "LaunchMultipleRunsMutation" | ||
|
|
||
| @capture_error | ||
| @require_permission_check(Permissions.LAUNCH_PIPELINE_EXECUTION) |
There was a problem hiding this comment.
This permission check here can make the whole mutation fail, and in this case the output would be a single GrapheneUnauthorizedError so I believe your output should be a union of GrapheneLaunchMultipleRunsResult and GrapheneUnauthorizedError and also GraphenePythonError since we're using @capture_error.
Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality
Summary & Motivation
Add a backend GraphQL mutation to handle launching multiple runs
How I Tested These Changes
pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py50 passed, 18 warnings in 206.16s (0:03:26)
Changelog