[ui] Fix asset group outlines not rendering properly in Safari #24882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7fbc0e8. |
bengotow
force-pushed
the
bengotow-2024-10/FE-570
branch
from
314535c
to
7fbc0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes FE-570
I'd seen this happen a couple other times -- Safari seems to have an annoying bug where you can't "position" the first DOM node inside a foreignObject. To use things like marginTop / top / inset, etc. we have to have at least one div above the positioned one in the foreignObject.
I created a named wrapper for this case because I think I'm likely to drive-by and remove this wrap layer otherwise :-)
How I Tested These Changes
Tested in Firefox, Chrome and Safari
Before:
After:
Changelog
Insert changelog entry or "NOCHANGELOG" here.
BUGFIXFixed asset group outlines not rendering properly in Safari