Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Change logger behavior so that setting a default logger in a Definitions object changes the logger by default, without needing to set run config to enable it #24338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 10, 2024

  1. Change logger behavior so that setting a default logger in a Definiti…

    …ons object actually sticks, without needing to set run config
    
    Summary:
    Right now if you customize a logger on a job, you also need to set additional configuration on the run when launching the job in order for it to actually use that logger and not fall back to the detault system logger. This is quite different than what happens when you set an executor on a job, and is generally confusing.
    
    This PR instead makes setting logger config more like executor config - if you set it, it is assumed that you want to use that logger, and applies that configuraiton as the default even if no configuration is set.
    
    The main blocker here is probably that this could be considered a breaking change - before, when you specified a logger on a job you were giving your self the option of opting into it, and now you are overriding whatever loggers you set as the default loggers.
    gibsondan committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5268842 View commit details
    Browse the repository at this point in the history