[ui] Move Observe Sources into the Materialize button #23764
Conversation
|
Edit: also going to move the tooltip to the left on the main button so that this doesn't happen |
bengotow
force-pushed
the
bengotow-2024-08/FE-517
branch
2 times, most recently
from
f1f4621
to
32a00eb
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2311c74. |
| export const useExecuteAssetMenuItem = ( | ||
| path: string[], | ||
| definition: { | ||
| assetKey: AssetKeyInput; | ||
| isObservable: boolean; | ||
| isExecutable: boolean; | ||
| isPartitioned: boolean; | ||
| hasMaterializePermission: boolean; | ||
| } | null, |
There was a problem hiding this comment.
Can we make this type more closely resemble the Asset type so we can avoid needing to attach the asset key to the definition?
There was a problem hiding this comment.
It looks like the inconsistencies are 1) isParittioned vs partitionDefinition and 2) assetKey in the object or not.
I think that we can update the AssetTableFragment to request these two fields and it'll align these. Going to do it in a quick separate PR bc it'll change a bunch of files.
js_modules/dagster-ui/packages/ui-core/src/assets/AssetTable.tsx
Outdated
Show resolved
Hide resolved
bengotow
force-pushed
the
bengotow-2024-08/FE-517
branch
2 times, most recently
from
40d6aa4
to
5cf2e51
Compare
bengotow
force-pushed
the
bengotow-2024-08/FE-517
branch
from
5cf2e51
to
2311c74
Compare
|
Retested this in cloud using the app-proxy and it's all still working as intended after the rebase, going to merge in the AM tomorrow. |
Summary & Motivation
Related: https://linear.app/dagster-labs/issue/FE-517/remove-observe-sources-button-add-to-materialize-all-dropdown
Loom:
https://www.loom.com/share/2e044d1117734c2dbfff4fb4bef2a570
This PR folds the Observe Sources button into the Materialize button, which brings the Observe option to the asset catalog! I also updated the asset menus to use the same logic for building their menu items so the behavior is consistent.
How I Tested These Changes
There's pretty good test coverage of this button and it's updated + still passing
I tested this manually with observable, materializable, external, and non-SDA assets to kick the tires :-)