Adding labels to clusters #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to middle) location using clusterLabelPos as an option for setNode.
|
Looks good! It would be possible to get the edges to route around the cluster label by doing some of this in dagre - e.g. adding a dummy node to the cluster at the right rank with the size of the label. |
|
Looking at the "Clusters" demo (http://cpettitt.github.io/project/dagre-d3/latest/demo/clusters.html) I cannot see any label of cluster. I expect the labels "Group", "Top Group" and "Bottom Group". What's missing? |
|
Fixed in #180. This will show up in v0.4.9. |
|
Cool, thank you for fast support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding labels to clusters with option of 'top' or 'bottom' (defaults to middle) location using clusterLabelPos as an option for setNode. Should add link to cluster.html from the demo directory to the wiki. Will need to do a make dist to get the cluster.html working. This is in support of issue #140.