Spring cleaning 2023: bug fixes, updates, and improvements #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagpunk
added
bug
This type of feature could be re-added later, but it would need to be fairly automated. GitHub's built-in release notes functionality provides the same purpose as a manual changelog in markdown.
This was
linked to
issues
Mar 4, 2023
This option is controlled by the .flake8 dotfile
Updated the pylint control file after receiving this error in GitHub Actions: "pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.BaseException' ?) instead" The fix is to prefix `builtins.` to the existing entries for this config option.
Improve the testing of exceptions using pytest.raises(). Closes #77
Check both type and value, allowing only int values greater than zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
dev-requirements.inandrequirements.in(closes Separate user and dev requirements #60)pandas, was added to the template's example code to support clear separation between dev and user requirements (closes Introduce a 3rd party dependency #90)Issues fixed
ValueError - int not callablewhen running flake8 by updating project dependency versions and modifying the package installation process in the GitHub Actionstestworkflow (closes Fix issue with flake8 linter #108)Improvements
foopackage==3.2.7 => foopackage>=3.2)pytest-xdistas a default dependency. Users can add this to their projects when needed and if they are okay with the added complexity. In the future,pytest-xdistcould be an option to include in a template wizard.CodeQLas a default CI/CD workflow. Users can add this to their projects when needed and if they are okay with the added complexity. CodeQL does not work well with private repositories, which makes its default inclusion an immediate hurdle for users who want to use the template in a new private repository. In the future, CodeQL could be an option to include in a template wizard. (closes Remove CodeQL from template #111)pytestexception testing approach usingpytest.raises()(closes Pytest exception handling and testing improvement #77)Maintenance