Skip to content

Remove the polyfill dependency - #2

Closed
grouville wants to merge 1 commit into
dagger:mainfrom
grouville:polyfill-removal
Closed

grouville wants to merge 1 commit into
dagger:mainfrom
grouville:polyfill-removal

Conversation

@grouville

@grouville grouville commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Ruff no longer needs dagger/polyfill for project discovery.

Workspace.findRoots now provides the intended policy directly: find projects below the current directory, or the nearest enclosing project when Dagger starts inside one. The Ruff execution path is unchanged.

Test

dagger check 'ruff:*'

Requires dagger/dagger#13854.

@grouville grouville changed the title Drop the polyfill for the engine's findConfigDirs Remove the polyfill dependency Aug 13, 2026
Ruff used dagger/polyfill to find every marked project below the current directory plus the nearest enclosing project.

Workspace.findRoots now provides that policy directly. Switch discovery to the native API, remove the polyfill dependency, and bump the engine requirement in the same change.

Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
@eunomie

eunomie commented Aug 25, 2026

Copy link
Copy Markdown
Member

Superseded by #3, which reworks the polyfill removal against engine v1.0.0-beta.10. This PR's head branch lives on a fork without push access, so it could not be updated in place — closing in favor of #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants