Repository navigation
Conversation
Signed-off-by: Yves Brissaud <yves@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@startto mark a function as a service fordagger start(dagger/dagger#14218). The engine part is dagger/dagger#14328.@startsets the same flag@updid, so registration still callsFunction.withUp. The wire name does not change, so this works on engines that predatestart.@upkeeps working. It is deprecated withtyping_extensions.deprecated, which emits aDeprecationWarningthat points at@start. Python filters that warning by default, so existing modules run unchanged.startis exported next toupindagger.mod.__all__, sofrom dagger import startworks.This mirrors the
sdk/pythonchange in dagger/dagger#14328.The
with_updocstring insdk/src/dagger/client/gen.pystill says "dagger up". That file is generated from the engine schema and changes when the engine pin moves past dagger/dagger#14328.Testing:
uv run --frozen pytest -q tests/client tests/codegen tests/mod: new tests cover@startin both decorator orders, and@upwarning while still marking a service.start:dagger up -llists both the@startand the@upfunction, anddagger up proof:webserves the@startservice on the forwarded port.