Fix incremental build Java generation. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
Jan 7, 2025
| @Test | ||
| void convertsToJava() throws IOException { | ||
| var dir = new File("examples/java"); | ||
| // N.B. Theis path is set in DafnyPlugin.java, then Dafny adds "-java" suffix |
There was a problem hiding this comment.
Suggested change
| // N.B. Theis path is set in DafnyPlugin.java, then Dafny adds "-java" suffix | |
| // N.B. This path is set in DafnyPlugin.java, then Dafny adds "-java" suffix |
robin-aws
requested changes
Jan 7, 2025
examples/java/src/main/dafny/Foo.dfy
Outdated
| @@ -0,0 +1,5 @@ | |||
| module Foo { | |||
| datatype Bar = create(baz: string) { | |||
There was a problem hiding this comment.
Suggested change
| datatype Bar = create(baz: string) { | |
| datatype Bar = Create(baz: string) { |
nit: Dafny style guide says to use PascalCase for Datatype
Translate task is requested to put generated source into a target directory "main", however dafny actually places it into a directory callled "main-java" and the translate task performs a rename at the end to compensate. The problem is this rename can fail, for example on an incremental build, when the target directory already exists. Instead keep "main-java" as target and pass this modified target onto subsequent gradle tasks as new source to be compiled.
robin-aws
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate task is requested to put generated source into a target directory "main", however dafny actually places it into a directory callled "main-java" and the translate task performs a rename at the end to compensate. The problem is this rename can fail, for example on an incremental build, when the target directory already exists.
Instead keep "main-java" as target and pass this modified target onto subsequent gradle tasks as new source to be compiled.