Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for version v1.4.0 #132

Merged
merged 22 commits into from
Nov 4, 2020
Merged

Prepare for version v1.4.0 #132

merged 22 commits into from
Nov 4, 2020

Conversation

daffidwilde
Copy link
Owner

  • Add abstract classes
  • Implement extended algorithms
  • Move algorithms to their own module

daffidwilde added 22 commits July 14, 2020 22:51
@daffidwilde
Move algorithms to submodule (#121)
7009f68 
* Update imports and wording in tests.

* Update subpackage inits and util files.

* Move algorithm funcs to algorithm subpackage.

* Format codebase with isort, black, flake8.

* Update API docs.
@daffidwilde
Make Player.forget() protected.
f756e97 
i.e. /forget/_forget
@daffidwilde
Move to _forget in all tests.
663b713
@daffidwilde
Move to _forget in SA player classes.
795f2fa 
These players have their own forget methods.
@daffidwilde
Move to _forget in base game and util function.
f0c4331
@daffidwilde
Move to _forget in games.
f1633fe
@daffidwilde
Protect Player.match() and Player.unmatch()
22e28b5
@daffidwilde
Move to _(un)match in other player tests.
5d1ddff
@daffidwilde
Move to _unmatch in SR example test.
7c7e382
@daffidwilde
Move to _(un)match in all player classes.
8d7a663
@daffidwilde
Move to _(un)match in games and util functions.
e08997e
@daffidwilde
Protect the delete and match functions.
d22a06a 
The ones in `matching.games.util` are for matching/deleting pairs.
@daffidwilde
Make relevant changes to game calls.
bec249c
@daffidwilde
Minor formatting fixes.
3aa0257
@daffidwilde
Merge branch 'v1.4-prep' into make-forget-a-protected-method
0835a7c
@daffidwilde
Merge branch 'make-forget-a-protected-method' into v1.4-prep
2bd789c
@daffidwilde
Implement extended algorithms (from book) (#130)
ba43799 
* Implement extended algorithms (from book)

Thanks to The Good Book (citation in `stable_roommates.py`), some minor
adjustments to HR and SM (nothing functionally different), and a
complete overhaul of SR have been implemented.

* Fix formatting.

* Add GusfieldIrving citation to bibliography.
@daffidwilde
Add more abstract classes (#122)
bcf1f62 
* Write tests for new matching classes.

* Write tests for new base class structure.

* Clean up old tests.

* Implement base classes for players and matchings.

* Add compatability to games and hospital classes.

* Update game class tests.

* Catch attribute typo in supervisor.

* Add compatability to other player tests.

* Catch attribute typo in SR test.

* Implement composite strategies for HR tests.

* Update game class tests.

Catch attribute typo in supervisor.

Add compatability to other player tests.

Catch attribute typo in SR test.

* Start implementing composites with SR.

* Format codebase.

* Catch typo in SA tutorial.

* Update classes in README

* Format codebase with black>19

* Add first phase check to SR.

* Fix (now-outdated) logic in tests.
@daffidwilde
Add NoStableMatchingWarning for SR (#131)
917e5e3 
* Add warning catcher to algorithm tests.

* Add warning catcher to solver tests.

* Add no solution example from GS62.

* Implement `NoStableMatchingWarning` source code.
@daffidwilde
Drop CI support for 3.6 (add in 3.9)
66b718a 
Also, run the flake8 linter.
@daffidwilde
Fix typo in CI flake8 call (snuck in last commit)
3445d3b
@daffidwilde
Update changelog and version number.
e0741a6
@daffidwilde daffidwilde merged commit e80f593 into main Nov 4, 2020
@daffidwilde daffidwilde deleted the v1.4-prep branch November 4, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daffidwilde