Make player cleaning internal #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `_remove_player` method to `BaseGame`. Allow for the removal of a player from a party, and make every player in another party forget them. * Write tests for HR solver. * Implement player cleaning at instantiation. * Format codebase. * Fix typo in HR source. * Unify hospital-resident selection in tests. * Fix unification to go the other way. The former `.forget()` call was needed. This fixes that and adds one into the `reciprocates_all_prefs` test.
* Write tests for SA solver. * Allow for no `other_party` in `_remove_player`. * Implement and test remaining SA behaviours. * Remove default `other_party` from `_remove_player` This behaviour is now within `StudentAllocation._remove_player`. * Force warnings every time by default. * Catch weird cases in `from_dictionaries` SA test. * Format codebase. * Add trailing comma flag to isort call in CI.
* Move to `exceptions` over `warning` * Update relevant tests and source code in HR/SA. * Add a `MatchingError` exception for post-checks. * Format codebase with isort and black. * Generalise post-solve checks (#119) * Generalise for SA. * Give attributes to MatchingError class. * Update validity checks for SA. * Move general validity checks under HR. * Have SA inherit from HR. * Clear up rebase for HR. Messed up a rebase. This fixes that. * Fix remaining issues from rebase in SA. * Opt for "issue" over "error" in checks. * Generalise for SM. * Generalise for SR. * Move Game check functions to Player classes. * Add in extra unit tests for hospitals and players. * Implement new player methods in game checks. * Format codebase with isort and black.
* Add clean parameter to HR tests. * Modularise checks out to BaseGame; add clean to HR * Format codebase with isort and black. * Catch failing test for Hospital class. * Add unit test for hospital oversubbed check. * Implement clean parameter for SA. * Format codebase with isort and black. * Make clean parameter optional in SA dict creation. * Catch stray hypothesis clean params. * Add unit test for unique preferences in game. * Add integration tests for HR validity checks. * Add extra tests for SA player removal coverage. * Make minor grammatical tweaks. * Make more rigorous the input checking processes. * Format codebase with isort and black. * Format codebase with isort, black, flake8. * Format tests. * Final linting from flake8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the point raised in #112 about a more organic interface, this PR moves the cleaning of players and their preferences into the scope of
matching.This will be achieved by refactoring the
_check_inputsolver methods to give out warnings rather than errors. In addition, theBaseGameinstance will change itsPlayerinstances, storing the original information as needed.