Skip to content

Commit

Permalink
Test that measured data work with failed reals
Browse files Browse the repository at this point in the history
This caused the misfit preprocessor to fail when run
on cases that have failed realizations.
  • Loading branch information
dafeda committed Sep 26, 2023
1 parent 0b8b74a commit b756eba
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/ert/data/_measured_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,11 @@ def _get_data(
response = ensemble.load_response(
group, tuple(ensemble.realization_list(RealizationState.HAS_DATA))
)
_msg = f"No response loaded for observation key: {key}"
if not response:
raise ResponseError(_msg)
except KeyError as e:
raise ResponseError(
f"No response loaded for observation key: {key}"
) from e
raise ResponseError(_msg) from e
ds = obs.merge(
response,
join="left",
Expand Down
4 changes: 4 additions & 0 deletions tests/unit_tests/gui/test_full_manual_update_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from qtpy.QtCore import Qt, QTimer
from qtpy.QtWidgets import QApplication, QComboBox, QMessageBox, QPushButton, QWidget

from ert.data import MeasuredData
from ert.gui.ertwidgets.caselist import CaseList
from ert.gui.simulation.ensemble_experiment_panel import EnsembleExperimentPanel
from ert.gui.simulation.run_dialog import RunDialog
Expand Down Expand Up @@ -127,6 +128,9 @@ def handle_dialog():
df_prior = facade.load_all_gen_kw_data(storage.get_ensemble_by_name("iter-0"))
df_posterior = facade.load_all_gen_kw_data(storage.get_ensemble_by_name("iter-1"))

# Making sure measured data works with failed realizations
MeasuredData(facade, storage.get_ensemble_by_name("iter-0"), ["POLY_OBS"])

# We expect that ERT's update step lowers the
# generalized variance for the parameters.
assert (
Expand Down

0 comments on commit b756eba

Please sign in to comment.