Return proper error

daenamkim · Mar 13, 2015 · 0340339 · 0340339
1 parent a026648
commit 0340339
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/core/chain_manager.go b/core/chain_manager.go
@@ -449,6 +449,8 @@ func (self *ChainManager) InsertChain(chain types.Blocks) error {
 				*/
 
 				self.setTransState(state.New(block.Root(), self.stateDb))
+				self.setTxState(state.New(block.Root(), self.stateDb))
+
 				queue[i] = ChainEvent{block}
 				queueEvent.canonicalCount++
 			} else {

diff --git a/core/error.go b/core/error.go
@@ -78,7 +78,7 @@ func (err *NonceErr) Error() string {
 }
 
 func NonceError(is, exp uint64) *NonceErr {
-	return &NonceErr{Message: fmt.Sprintf("Nonce err. Is %d, expected %d", is, exp), Is: is, Exp: exp}
+	return &NonceErr{Message: fmt.Sprintf("Transaction w/ invalid nonce (%d / %d)", is, exp), Is: is, Exp: exp}
 }
 
 func IsNonceErr(err error) bool {

diff --git a/core/state_transition.go b/core/state_transition.go
@@ -148,6 +148,9 @@ func (self *StateTransition) preCheck() (err error) {
 
 	// Pre-pay gas / Buy gas of the coinbase account
 	if err = self.BuyGas(); err != nil {
+		if state.IsGasLimitErr(err) {
+			return err
+		}
 		return InvalidTxError(err)
 	}
 

diff --git a/miner/worker.go b/miner/worker.go
@@ -212,6 +212,7 @@ gasLimit:
 			fallthrough
 		case core.IsInvalidTxErr(err):
 			// Remove invalid transactions
+			self.chain.TxState().RemoveNonce(tx.From(), tx.Nonce())
 			remove = append(remove, tx)
 		case state.IsGasLimitErr(err):
 			// Break on gas limit